💄 PnL code structure alignement #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mraniki - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
+27
to
+41
| Methods: | ||
| get_quote(self, instrument) | ||
| get_offer(self, instrument) | ||
| get_bid(self, instrument) | ||
| get_account_balance(self) | ||
| get_account_position(self) | ||
| calculate_pnl(self, period=None) | ||
| get_account_pnl(self, start_date) | ||
| execute_order(self, order_params) | ||
| get_trading_asset_balance(self) | ||
| get_order_amount(self, quantity, instrument, is_percentage) | ||
| pre_order_checks(self, order_params) | ||
| replace_instrument(self, instrument) | ||
| get_instrument_decimals(self, instrument) | ||
| get_trade_confirmation(self, order_params) |
There was a problem hiding this comment.
suggestion (code_clarification): Consider documenting method purposes in the class docstring.
While listing methods in the class docstring provides an overview, including a brief description of each method's purpose or functionality could enhance readability and maintainability.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 71.19% 70.99% -0.20%
==========================================
Files 7 7
Lines 427 431 +4
==========================================
+ Hits 304 306 +2
- Misses 123 125 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.